zhztheplayer commented on code in PR #8169:
URL: https://github.com/apache/incubator-gluten/pull/8169#discussion_r1875206946
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/BatchScanExecTransformer.scala:
##########
@@ -169,4 +170,13 @@ abstract class BatchScanExecTransformerBase(
case "ClickHouseScan" => ReadFileFormat.MergeTreeReadFormat
case _ => ReadFileFormat.UnknownFormat
}
+
+ override def simpleString(maxFields: Int): String = {
+ val truncatedOutputString = truncatedString(output, "[", ", ", "]",
maxFields)
+ val runtimeFiltersString = s"RuntimeFilters:
${runtimeFilters.mkString("[", ",", "]")}"
+ val nativeFiltersString = s"nativeFilters: ${filterExprs().mkString("[",
",", "]")}"
Review Comment:
Nit: Do we prefer `NativeFilters` than `nativeFilters`?
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/FileSourceScanExecTransformer.scala:
##########
@@ -190,6 +193,18 @@ abstract class FileSourceScanExecTransformerBase(
case "CSVFileFormat" => ReadFileFormat.TextReadFormat
case _ => ReadFileFormat.UnknownFormat
}
+
+ override def simpleString(maxFields: Int): String = {
+ val metadataEntries = metadata.toSeq.sorted.map {
+ case (key, value) =>
+ key + ": " + StringUtils.abbreviate(redact(value),
maxMetadataValueLength)
+ }
+ val metadataStr = truncatedString(metadataEntries, " ", ", ", "",
maxFields)
+ val nativeFiltersString = s"nativeFilters: ${filterExprs().mkString("[",
",", "]")}"
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
