PHILO-HE commented on code in PR #8116:
URL: https://github.com/apache/incubator-gluten/pull/8116#discussion_r1875378305
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarSubqueryBroadcastExec.scala:
##########
@@ -64,6 +65,14 @@ case class ColumnarSubqueryBroadcastExec(
copy(name = "native-dpp", buildKeys = keys, child = child.canonicalized)
}
+ // Copy from
org.apache.spark.sql.execution.joins.HashJoin#canRewriteAsLongType
+ // we should keep consistent with it to identify the LongHashRelation.
+ private def canRewriteAsLongType(keys: Seq[Expression]): Boolean = {
Review Comment:
@yikf, if spark changes this logic, e.g., for adding support for other
types, unexpected failure can happen in Gluten? Seems there is no other way.
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarSubqueryBroadcastExec.scala:
##########
@@ -64,6 +65,14 @@ case class ColumnarSubqueryBroadcastExec(
copy(name = "native-dpp", buildKeys = keys, child = child.canonicalized)
}
+ // Copy from
org.apache.spark.sql.execution.joins.HashJoin#canRewriteAsLongType
+ // we should keep consistent with it to identify the LongHashRelation.
+ private def canRewriteAsLongType(keys: Seq[Expression]): Boolean = {
Review Comment:
@yikf, if spark changes this logic on its side, e.g., for adding support for
other types, unexpected failure can happen in Gluten? Seems there is no other
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
