yikf opened a new pull request, #8186: URL: https://github.com/apache/incubator-gluten/pull/8186
## What changes were proposed in this pull request? This PR aims to change loadQuantum default value to 8MB from 258MB. Velox currently only [support up to 8MB load quantum size on SSD](https://github.com/facebookincubator/velox/blob/main/velox/dwio/common/CachedBufferedInput.h#L182) and add a limit on loadQuantum by https://github.com/facebookincubator/velox/commit/c6d7390db644e0d0769f248e5b3c271dea8f58b1. We should modify the default values to make them user-friendly out of the box and unnecessary large values. ```c++ // We only support up to 8MB load quantum size on SSD and there is no need for // larger SSD read size performance wise. void checkLoadQuantum() { if (cache_->ssdCache() != nullptr) { VELOX_CHECK_LE( options_.loadQuantum(), 1 << cache::SsdRun::kSizeBits, "Load quantum exceeded SSD cache entry size limit."); } } ``` ## How was this patch tested? doc only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
