marin-ma commented on code in PR #8231: URL: https://github.com/apache/incubator-gluten/pull/8231#discussion_r1883731703
########## cpp/core/shuffle/Payload.cc: ########## @@ -310,7 +310,7 @@ arrow::Result<std::vector<std::shared_ptr<arrow::Buffer>>> BlockPayload::deseria RETURN_NOT_OK(inputStream->Read(sizeof(uint32_t), &numRows)); uint32_t numBuffers; RETURN_NOT_OK(inputStream->Read(sizeof(uint32_t), &numBuffers)); - timer.reset(); + deserializeTime += timer.realTimeUsed(); Review Comment: Why do we need this change? timer.start() and timer.stop() is not called. the realTimeUsed would be zero -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
