FelixYBW commented on PR #7521: URL: https://github.com/apache/incubator-gluten/pull/7521#issuecomment-2549388743
> > Yes, in general the private changes are reduced to decimal avg, parquet struct reader, timestamp support - which requires more time on align on the design/code with Velox community > Let's follow up the PRs. > The changes in get_velox.sh is not maintained well, some of them are not used any more. BTW it's not used if you are using vcpkg based static build. > Good to know. Let's add comments there and don't maintain it. > The two changes in "modify_velox.patch" is reduced since last month and the rest changes are not supported by Velox community. We may need more time to discuss with them to align. > If Velox community doesn't accept it, let's put it as a commit in oap/velox instead of a patch to apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
