zhztheplayer commented on code in PR #8262:
URL: https://github.com/apache/incubator-gluten/pull/8262#discussion_r1889479637
##########
gluten-core/src/main/java/org/apache/gluten/memory/memtarget/MemoryTargets.java:
##########
@@ -86,7 +88,8 @@ public static TreeMemoryTarget newConsumer(
consumer,
() -> {
LOGGER.info("Request for spilling on consumer {}...",
consumer.name());
- long spilled = TreeMemoryTargets.spillTree(consumer, Long.MAX_VALUE);
+ // Note: Spill from root node so other consumers also get spilled.
+ long spilled = TreeMemoryTargets.spillTree(root, Long.MAX_VALUE);
Review Comment:
It's the core fix. @kecookier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
