jinchengchenghh commented on code in PR #8273:
URL: https://github.com/apache/incubator-gluten/pull/8273#discussion_r1893356125
##########
backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala:
##########
@@ -27,12 +27,20 @@ case class PartialProjectRule(spark: SparkSession) extends
Rule[SparkPlan] {
plan.transformUp {
case plan: ProjectExec =>
val transformer = ColumnarPartialProjectExec.create(plan)
- if (transformer.doValidate().ok()) {
- if
(transformer.child.asInstanceOf[ColumnarPartialProjectExec].doValidate().ok()) {
+ val validationResult = transformer.doValidate()
+ if (validationResult.ok()) {
+ val childValidationResult =
+
transformer.child.asInstanceOf[ColumnarPartialProjectExec].doValidate()
Review Comment:
Maybe we should respect GlutenConfig `spark.gluten.sql.validation.logLevel`,
add some code in
https://github.com/apache/incubator-gluten/blob/main/gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala#L86,
If the result is not OK, log as this level. I think some refactors may break
log, we don't expect catch exception here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
