yikf commented on code in PR #8245:
URL: https://github.com/apache/incubator-gluten/pull/8245#discussion_r1893482802
##########
gluten-core/src/main/scala/org/apache/gluten/softaffinity/SoftAffinityManager.scala:
##########
@@ -88,6 +90,13 @@ abstract class AffinityManager extends LogLevelUtil with
Logging {
}
})
+ private var hashRing: Option[ConsistentHash[ExecutorNode]] = _
Review Comment:
Thanks for you suggestion, only the manager is aware of the changes in the
executor now, moving to the strategy requires that the strategy has the
relevant interfaces for the executor's changes. the current soft affinity code
is not very friendly in terms of extensibility, and we can refactor it in
subsequent PRs to achieve better extensibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
