yikf commented on code in PR #8188:
URL: https://github.com/apache/incubator-gluten/pull/8188#discussion_r1894537025
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -229,7 +229,10 @@ jint JNI_OnLoad(JavaVM* vm, void* reserved) {
metricsBuilderClass = createGlobalClassReferenceOrError(env,
"Lorg/apache/gluten/metrics/Metrics;");
metricsBuilderConstructor = getMethodIdOrError(
- env, metricsBuilderClass, "<init>",
"([J[J[J[J[J[J[J[J[J[JJ[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J)V");
+ env,
+ metricsBuilderClass,
+ "<init>",
+
"([J[J[J[J[J[J[J[J[J[JJ[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J)V");
Review Comment:
@WangGuangxin I investigated the FFM API[1][2] and it seems that there is no
way to create and call Java objects from the native side. Can you provide some
information on this?
[1]
https://docs.oracle.com/en/java/javase/22/core/foreign-function-and-memory-api.html
[2] https://openjdk.org/jeps/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
