PHILO-HE commented on code in PR #8338:
URL: https://github.com/apache/incubator-gluten/pull/8338#discussion_r1897696029
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -301,7 +301,7 @@ bool SubstraitToVeloxPlanValidator::validateCast(
return false;
case TypeKind::TIMESTAMP:
// Only support cast timestamp to date
Review Comment:
@zml1206, thanks for your comment! Yes, Spark UTs have uncovered some wrong
result issue. I am still trying to fix all issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]