PHILO-HE commented on code in PR #8399:
URL: https://github.com/apache/incubator-gluten/pull/8399#discussion_r1901541368
##########
.github/workflows/velox_backend.yml:
##########
@@ -566,7 +566,7 @@ jobs:
- name: TPC-H SF1.0 && TPC-DS SF1.0 Parquet local spark3.2 with ${{
matrix.celeborn }}
run: |
EXTRA_PROFILE=""
- if [ "${{ matrix.celeborn }}" = "celeborn-0.4.2" ]; then
Review Comment:
@SteNicholas, your changes for dockerfile will make this new celeborn
release installed in docker image once your pr is merged. I recommend you to
include the below changes in your pr to allow binary package doesn't exist in
docker image temporarily. Does it make sense?
```
diff --git a/.github/workflows/velox_backend.yml
b/.github/workflows/velox_backend.yml
index ada2ea3f2..dfbd6b93c 100644
--- a/.github/workflows/velox_backend.yml
+++ b/.github/workflows/velox_backend.yml
@@ -572,6 +572,10 @@ jobs:
EXTRA_PROFILE="-Pceleborn-0.5"
fi
echo "EXTRA_PROFILE: ${EXTRA_PROFILE}"
+ if [ ! -e "/opt/apache-${{ matrix.celeborn }}-bin.tgz" ]; then
+ echo "WARNING: please pre-install your required package in
docker image since the downloading is throttled by this site."
+ wget -nv https://archive.apache.org/dist/celeborn/${{
matrix.celeborn }}/apache-${{ matrix.celeborn }}-bin.tgz -P /opt/
+ fi
cd /opt && mkdir -p celeborn && \
tar xzf apache-${{ matrix.celeborn }}-bin.tgz -C /opt/celeborn
--strip-components=1 && cd celeborn && \
mv ./conf/celeborn-env.sh.template ./conf/celeborn-env.sh && \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
