jackylee-ch commented on code in PR #8422:
URL: https://github.com/apache/incubator-gluten/pull/8422#discussion_r1903622328
##########
gluten-ut/spark32/src/test/scala/org/apache/spark/sql/execution/adaptive/clickhouse/ClickHouseAdaptiveQueryExecSuite.scala:
##########
@@ -42,7 +43,8 @@ class ClickHouseAdaptiveQueryExecSuite extends
AdaptiveQueryExecSuite with Glute
override def sparkConf: SparkConf = {
super.sparkConf
- .set("spark.gluten.sql.columnar.forceShuffledHashJoin", "false")
+ .set(GlutenConfig.COLUMNAR_FORCE_SHUFFLED_HASH_JOIN_ENABLED.key, "false")
+ .set(GlutenConfig.NOOP_WRITER_ENABLED.key, "false")
Review Comment:
The following test will report an error, as `GlutenNoopWriterRule` will add
a `FakeRowAdaptor` node, which will cause the test check to fail, thus we
default false here.
```
SPARK-30953: InsertAdaptiveSparkPlan should apply AQE on child plan of v2
write commands
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
