baibaichen commented on code in PR #8400:
URL: https://github.com/apache/incubator-gluten/pull/8400#discussion_r1903917765
##########
cpp-ch/local-engine/local_engine_jni.cpp:
##########
@@ -1039,7 +1039,7 @@ JNIEXPORT jobject
Java_org_apache_spark_sql_execution_datasources_CHDatasourceJn
local_engine::BlockStripes bs =
local_engine::BlockStripeSplitter::split(*block, partition_col_indice_vec,
hasBucket, reserve_);
auto * addresses = env->NewLongArray(bs.block_addresses.size());
- env->SetLongArrayRegion(addresses, 0, bs.block_addresses.size(),
bs.block_addresses.data());
+ env->SetLongArrayRegion(addresses, 0, bs.block_addresses.size(), (const
jlong *)bs.block_addresses.data());
Review Comment:
> may be reinterpret_cast
let's use `static_cast` first for safety
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
