taiyang-li commented on code in PR #8351:
URL: https://github.com/apache/incubator-gluten/pull/8351#discussion_r1904811524
##########
cpp-ch/local-engine/Functions/SparkFunctionCheckDecimalOverflow.cpp:
##########
@@ -121,7 +121,17 @@ class FunctionCheckDecimalOverflow : public IFunction
if (const ColVecType * col_vec =
checkAndGetColumn<ColVecType>(src_column.column.get()))
{
- executeInternal<FromFieldType, ToDataType>(*col_vec,
result_column, input_rows_count, precision, scale);
+ executeInternal<FromDataType, ToDataType,
ColVecType>(*col_vec, result_column, input_rows_count, precision, scale);
+ return true;
+ }
+ }
+ else if constexpr (IsDataTypeNumber<FromDataType>)
Review Comment:
above if and else if should be merged. Remind: use `using ColVecType =
ColumnVectorOrDecimal<T>;
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
