yikf commented on PR #8431: URL: https://github.com/apache/incubator-gluten/pull/8431#issuecomment-2574247304
> @yikf Thanks for bringing the code back. Is there any performance-related change you wanted to highlight between this one and the original PR? yes, after splitting the original PR, we identified the issue as being related to the current PR's changes. after offline discussion and investigation with @baibaichen , it was determined that the problem was caused by [the modification](https://github.com/apache/incubator-gluten/pull/8431/files#diff-b8683791e484f47ab4b26a2ce32d7a4760dc276ae0bc7621e8a500df11936d93R40). Now, we have avoided synchronization and copying. Last night, @baibaichen verified this PR and there are no performance issues now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
