zhztheplayer commented on code in PR #8445:
URL: https://github.com/apache/incubator-gluten/pull/8445#discussion_r1905023341
##########
tools/gluten-it/common/src/main/scala/org/apache/gluten/integration/action/Queries.scala:
##########
@@ -141,17 +153,18 @@ object Queries {
}
private def runQuery(
- runner: QueryRunner,
- creator: TableCreator,
- session: SparkSession,
- id: String,
- desc: String,
- explain: Boolean,
- randomKillTasks: Boolean): TestResultLine = {
+ runner: QueryRunner,
+ creator: TableCreator,
+ session: SparkSession,
+ id: String,
+ desc: String,
+ explain: Boolean,
+ metricMapper: MetricMapper,
+ randomKillTasks: Boolean): TestResultLine = {
Review Comment:
Thank you for catching! `gluten-it` is not subject to the main repo's linter
configurations, which definitely needs to improve. I'll update this PR and
enable code style checks in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
