This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new fe02feefb8 [VL] Remove an out-of-date warning message (#8447)
fe02feefb8 is described below
commit fe02feefb8ea11f2b00c3c98713b5c034d1cd47a
Author: Hongze Zhang <[email protected]>
AuthorDate: Tue Jan 7 17:03:48 2025 +0800
[VL] Remove an out-of-date warning message (#8447)
---
cpp/velox/compute/VeloxBackend.cc | 4 ----
.../java/org/apache/gluten/integration/command/Parameterized.java | 2 +-
.../src/main/java/org/apache/gluten/integration/command/Queries.java | 2 +-
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/cpp/velox/compute/VeloxBackend.cc
b/cpp/velox/compute/VeloxBackend.cc
index 3beda67539..328cd72485 100644
--- a/cpp/velox/compute/VeloxBackend.cc
+++ b/cpp/velox/compute/VeloxBackend.cc
@@ -280,10 +280,6 @@ void VeloxBackend::initConnector() {
ioThreads >= 0,
kVeloxIOThreads + " was set to negative number " +
std::to_string(ioThreads) + ", this should not happen.");
if (ioThreads > 0) {
- LOG(WARNING)
- << "Velox background IO threads is enabled. Which is highly
unrecommended as of now, since it may cause"
- << " some unexpected issues like query crash or hanging. Please turn
it off if you are unsure about"
- << " this option.";
ioExecutor_ = std::make_unique<folly::IOThreadPoolExecutor>(ioThreads);
}
velox::connector::registerConnector(std::make_shared<velox::connector::hive::HiveConnector>(
diff --git
a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java
b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java
index 9ce910e0bb..0b96ae3c71 100644
---
a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java
+++
b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Parameterized.java
@@ -46,7 +46,7 @@ public class Parameterized implements Callable<Integer> {
@CommandLine.Option(names = {"--warmup-iterations"}, description = "Dry-run
iterations before actually run the test", defaultValue = "0")
private int warmupIterations;
- @CommandLine.Option(names = {"-m", "--metric"}, description = "Specify a
series of metrics to collect during execution")
+ @CommandLine.Option(names = {"-m", "--metric"}, description = "Specify a
series of executor metrics to collect during execution")
private String[] metrics = new String[0];
@CommandLine.Option(names = {"-d", "--dim"}, description = "Set a series of
dimensions consisting of possible config options, example:
-d=offheap:1g,spark.memory.offHeap.enabled=true,spark.memory.offHeap.size=1g")
diff --git
a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java
b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java
index b4ac90a6be..456998cb2f 100644
---
a/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java
+++
b/tools/gluten-it/common/src/main/java/org/apache/gluten/integration/command/Queries.java
@@ -44,7 +44,7 @@ public class Queries implements Callable<Integer> {
@CommandLine.Option(names = {"--random-kill-tasks"}, description = "Every
single task will get killed and retried after running for some time",
defaultValue = "false")
private boolean randomKillTasks;
- @CommandLine.Option(names = {"--collect-sql-metrics"}, description =
"Collect SQL metrics from run queries and generate a simple report based on
them. Available types: execution-time")
+ @CommandLine.Option(names = {"--sql-metrics"}, description = "Collect SQL
metrics from run queries and generate a simple report based on them. Available
types: execution-time")
private Set<String> collectSqlMetrics = Collections.emptySet();
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
