ArnavBalyan commented on code in PR #8454:
URL: https://github.com/apache/incubator-gluten/pull/8454#discussion_r1906504257
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarCachedBatchSerializer.scala:
##########
@@ -17,7 +17,7 @@
package org.apache.spark.sql.execution
import org.apache.gluten.backendsapi.BackendsApiManager
-import org.apache.gluten.columnarbatch.ColumnarBatches
+import org.apache.gluten.columnarbatch.{ColumnarBatches, VeloxColumnarBatches}
Review Comment:
Thanks for the review @FelixYBW @zhztheplayer!
Yes, the note was meant for that. Ideally the transitions should have added
the correct transition node before this, However the serializer is a special
case since it's not an operator and does not extend the GlutenPlan, I have some
ideas to explore this which may require some design changes in the serializer
to make it work with transitions.
Would it be possible to merge this for now since the ColumnarRange operator
depends on it and I'll work on the serializer compatibility for transitions,
let me know what you think thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
