zhztheplayer commented on code in PR #8321: URL: https://github.com/apache/incubator-gluten/pull/8321#discussion_r1908745762
########## shims/spark34/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AbstractBatchScanExec.scala: ########## @@ -57,7 +57,10 @@ abstract class AbstractBatchScanExec( override def hashCode(): Int = Objects.hashCode(batch, runtimeFilters) - @transient override lazy val inputPartitions: Seq[InputPartition] = batch.planInputPartitions() + @transient override lazy val inputPartitions: Seq[InputPartition] = inputPartitionsShim + + @transient protected lazy val inputPartitionsShim: Seq[InputPartition] = + batch.planInputPartitions() Review Comment: Why breaking the variable into two? Also, it the variable name `inputPartitionsShim` a little bit confusing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
