jackylee-ch commented on code in PR #8422: URL: https://github.com/apache/incubator-gluten/pull/8422#discussion_r1909756689
########## gluten-substrait/src/main/scala/org/apache/spark/sql/execution/datasources/noop/GlutenNoopWriterRule.scala: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution.datasources.noop + +import org.apache.spark.sql.SparkSession +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.execution.SparkPlan +import org.apache.spark.sql.execution.datasources.GlutenWriterColumnarRules.injectFakeRowAdaptor +import org.apache.spark.sql.execution.datasources.v2.{AppendDataExec, OverwriteByExpressionExec} + +/** + * A rule that injects a FakeRowAdaptor for NoopWrite. + * + * The current V2 Command does not support columnar. Therefore, when its child node is a + * ColumnarNode, Vanilla Spark inserts a ColumnarToRow conversion between V2 Command and its child. + * This rule replaces the inserted ColumnarToRow with a FakeRowAdaptor, effectively bypassing the + * ColumnarToRow operation for NoopWrite. Since NoopWrite does not actually perform any data + * operations, it can accept input data in either row-based or columnar format. + */ +case class GlutenNoopWriterRule(session: SparkSession) extends Rule[SparkPlan] { Review Comment: We cannot move to that folder as the `NoopWrite` can only be accessed under `org.apache.spark.sql.execution.datasources.noop` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
