yikf commented on code in PR #8480:
URL: https://github.com/apache/incubator-gluten/pull/8480#discussion_r1912627523


##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -301,43 +287,8 @@ class GlutenConfig(conf: SQLConf) extends Logging {
 
   def rasRough2VanillaCost: Long = getConf(RAS_ROUGH2_VANILLA_COST)
 
-  def enableVeloxCache: Boolean = getConf(COLUMNAR_VELOX_CACHE_ENABLED)

Review Comment:
   These methods for getting the configuration are actually not used; instead, 
the configuration is passed through to the native side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to