FelixYBW commented on code in PR #8525:
URL: https://github.com/apache/incubator-gluten/pull/8525#discussion_r1915714945
##########
cpp/core/benchmarks/CompressionBenchmark.cc:
##########
@@ -45,8 +45,13 @@ void printTrace(void) {
void* array[kMaxSize];
size = backtrace(array, kMaxSize);
strings = backtrace_symbols(array, size);
- for (i = 0; i < size; i++)
- printf(" %s\n", strings[i]);
+ for (i = 0; i < size; i++) {
+ if (strings[i] != nullptr) {
+ printf(" %s\n", strings[i]);
+ } else {
+ printf("It was null at i = %lu\n", i);
Review Comment:
It prints the symbols. You may either add an assert before print or just
ignore null pointer. Don't print the this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
