JkSelf commented on code in PR #8539:
URL: https://github.com/apache/incubator-gluten/pull/8539#discussion_r1915879703
##########
dev/docker/Dockerfile.centos8-dynamic-build-jdk17:
##########
@@ -0,0 +1,12 @@
+FROM apache/gluten:centos-8
+
+
+RUN yum install -y java-17-openjdk-devel patch wget git perl
+ENV JAVA_HOME=/usr/lib/jvm/java-17-openjdk
+ENV PATH=$JAVA_HOME/bin:$PATH
+
+ENV PATH=${PATH}:/usr/lib/maven/bin
+
+RUN git clone --depth=1 https://github.com/apache/incubator-gluten /opt/gluten
+
+RUN cd /opt/gluten && source /opt/rh/gcc-toolset-11/enable &&
./dev/builddeps-veloxbe.sh --run_setup_script=ON build_arrow && rm -rf
/opt/gluten
Review Comment:
nit: Add new blank line.
##########
.github/workflows/docker_image.yml:
##########
@@ -84,3 +86,11 @@ jobs:
file: dev/docker/Dockerfile.centos8-dynamic-build-jdk11
push: true
tags: apache/gluten:centos-8-jdk11
+
+ - name: Build and push Docker image Centos8 + JDK17
+ uses: docker/build-push-action@v2
+ with:
+ context: .
+ file: dev/docker/Dockerfile.centos8-dynamic-build-jdk17
+ push: true
+ tags: apache/gluten:centos-8-jdk17
Review Comment:
nit: Add new blank line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
