zml1206 commented on code in PR #8585:
URL: https://github.com/apache/incubator-gluten/pull/8585#discussion_r1924699407
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/heuristic/AddFallbackTags.scala:
##########
@@ -25,7 +25,10 @@ import org.apache.spark.sql.execution.SparkPlan
// Add fallback tags when validator returns negative outcome.
case class AddFallbackTags(validator: Validator) extends Rule[SparkPlan] {
def apply(plan: SparkPlan): SparkPlan = {
- plan.foreachUp { case p => addFallbackTag(p) }
+ plan.foreachUp {
+ case p if FallbackTags.maybeOffloadable(p) => addFallbackTag(p)
+ case _ =>
+ }
Review Comment:
Those that have been tagged do not need to validate again , and #8580 issus1
can be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
