ArnavBalyan commented on code in PR #8602:
URL: https://github.com/apache/incubator-gluten/pull/8602#discussion_r1926974245
##########
backends-velox/src/main/java/org/apache/gluten/columnarbatch/VeloxColumnarBatches.java:
##########
@@ -46,16 +46,7 @@ public static void checkVeloxBatch(ColumnarBatch batch) {
"Expected comprehensive batch type %s, but got %s",
COMPREHENSIVE_TYPE_VELOX,
ColumnarBatches.getComprehensiveLightBatchType(batch)));
}
-
- public static void checkNonVeloxBatch(ColumnarBatch batch) {
- if (ColumnarBatches.isZeroColumnBatch(batch)) {
- return;
- }
- Preconditions.checkArgument(
- !isVeloxBatch(batch),
- String.format("Comprehensive batch type is already %s",
COMPREHENSIVE_TYPE_VELOX));
- }
-
+
Review Comment:
Yes it seems to have crept in, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
