PHILO-HE commented on code in PR #8612:
URL: https://github.com/apache/incubator-gluten/pull/8612#discussion_r1929555451
##########
ep/build-velox/src/build_velox.sh:
##########
@@ -117,6 +127,9 @@ function compile {
echo "ENABLE_BENCHMARK is ON. Disabling Tests, GCS and ABFS connectors if
enabled."
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_BENCHMARKS=ON"
fi
+ if [ $ENABLE_VCPKG == "ON" ]; then
Review Comment:
Seems we can just rely on this check to see whether the below env variable
is set:
`if [ -n "${GLUTEN_VCPKG_ENABLED:-}" ];`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
