marin-ma commented on code in PR #8615:
URL: https://github.com/apache/incubator-gluten/pull/8615#discussion_r1933679439


##########
docs/Configuration.md:
##########
@@ -21,7 +21,7 @@ You can add these configurations into spark-defaults.conf to 
enable or disable t
 | spark.sql.join.preferSortMergeJoin                           | When true, 
prefer sort merge join over shuffled hash join. <br /> Note: Please turn off 
preferSortMergeJoin.                                                            
                                                                                
                                                                                
                                                                                
                                                                                
                                  | false                                       
         |
 | spark.plugins                                                | To load 
Gluten's components by Spark's plug-in loader                                   
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                  | org.apache.gluten.GlutenPlugin              
         |
 | spark.shuffle.manager                                        | To turn on 
Gluten Columnar Shuffle Plugin                                                  
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                               | 
org.apache.spark.shuffle.sort.ColumnarShuffleManager |
-| spark.gluten.enabled                                         | Enable 
Gluten, default is true. Just an experimental property. Recommend to 
enable/disable Gluten through the setting for `spark.plugins`.                  
                                                                                
                                                                                
                                                                                
                                                                                
                                              | true                            
                     |
+| spark.gluten.enabled                                         | Enable Gluten 
at runtime, default is true. It fallbacks to vanilla Spark for all query plans. 
Recommend to enable/disable Gluten through the setting for `spark.plugins`.     
                                                                                
                                                                                
                                                                                
                                                                                
                                                           | true               
                                  |

Review Comment:
   To be clearer "It fallbacks to vanilla Spark for all query plans if set to 
false."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to