marin-ma commented on code in PR #8593:
URL: https://github.com/apache/incubator-gluten/pull/8593#discussion_r1943102640
##########
gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetColumnIndexSuite.scala:
##########
@@ -38,7 +38,25 @@ class GlutenParquetColumnIndexSuite extends
ParquetColumnIndexSuite with GlutenS
"cast(id as float) as _5",
"cast(id as double) as _6",
"cast(id as decimal(20,0)) as _7",
- "cast(cast(1618161925000 + id * 1000 * 60 * 60 * 24 as timestamp) as
date) as _9"
+ "cast(cast(1618161925 + id * 60 * 60 * 24 as timestamp) as date) as _9"
Review Comment:
Why do we need this change here? Is it because larger timestamp will
overflow in Velox? Could add some comments like "// Change 1618161925000 to
1618161925 because ... " for explanations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
