This is an automated email from the ASF dual-hosted git repository.
yuanzhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 852340219f [VL] nit: Remove shadowed variables in
SubstraitToVeloxPlan.cc (#8677)
852340219f is described below
commit 852340219f87fb99cba3b0b9801967c6fb80d4c0
Author: Hongze Zhang <[email protected]>
AuthorDate: Fri Feb 7 09:14:08 2025 +0800
[VL] nit: Remove shadowed variables in SubstraitToVeloxPlan.cc (#8677)
gluten::kHiveConnectorId was defined as const so no need to define
kHiveConnectorId locally in the function bodies.
---
cpp/velox/substrait/SubstraitToVeloxPlan.cc | 5 -----
1 file changed, 5 deletions(-)
diff --git a/cpp/velox/substrait/SubstraitToVeloxPlan.cc
b/cpp/velox/substrait/SubstraitToVeloxPlan.cc
index b7fdc59dc4..3661b76084 100644
--- a/cpp/velox/substrait/SubstraitToVeloxPlan.cc
+++ b/cpp/velox/substrait/SubstraitToVeloxPlan.cc
@@ -667,8 +667,6 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
}
}
- // Do not hard-code connector ID and allow for connectors other than Hive.
- static const std::string kHiveConnectorId = "test-hive";
// Currently only support parquet format.
dwio::common::FileFormat fileFormat = dwio::common::FileFormat::PARQUET;
@@ -1273,9 +1271,6 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
SubstraitParser::parseColumnTypes(baseSchema, columnTypes);
}
- // Do not hard-code connector ID and allow for connectors other than Hive.
- static const std::string kHiveConnectorId = "test-hive";
-
// Velox requires Filter Pushdown must being enabled.
bool filterPushdownEnabled = true;
std::shared_ptr<connector::hive::HiveTableHandle> tableHandle;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
