j7nhai commented on PR #8674: URL: https://github.com/apache/incubator-gluten/pull/8674#issuecomment-2641815822
> This case shouldn't happen. See https://github.com/apache/incubator-gluten/blob/main/docs/velox-backend-support-progress.md#cast-functions-support-status > > > N/A: not applicable case, e.g., from type is as same as to type, where cast will not actually happen. > > Could you provide a sample to demonstrate when this code path will be called? ```scala sql("use test") sql("drop table if exists t1") sql("drop table if exists t2") sql("create table t1 (a TIMESTAMP) USING ICEBERG") sql("create table t2 (b TIMESTAMP) USING ICEBERG") sql("INSERT OVERWRITE t1 VALUES (CAST('2025-01-21 00:00:00' AS TIMESTAMP))") sql("INSERT OVERWRITE t1 SELECT * FROM t2") // Not supported to map spark function name to substrait function name: cast(b#7 as timestamp), class name: AnsiCast. ``` Then I try to convert AnsiCast to cast when origin type equal to dest type. And the native cast not support ts to ts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
