This is an automated email from the ASF dual-hosted git repository.
marong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new e009208945 [VL] Enable make_date function (#8683)
e009208945 is described below
commit e0092089453286b6822447a875666b41ab6f0b5c
Author: Zhen Li <[email protected]>
AuthorDate: Fri Feb 7 19:09:53 2025 +0800
[VL] Enable make_date function (#8683)
---
.../src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala | 3 ++-
.../org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala | 7 +++++++
.../scala/org/apache/gluten/expression/ExpressionMappings.scala | 1 +
.../main/scala/org/apache/gluten/expression/ExpressionNames.scala | 1 +
4 files changed, 11 insertions(+), 1 deletion(-)
diff --git
a/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
b/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
index 1dd815b6d7..dc2d8716b2 100644
---
a/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
+++
b/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
@@ -204,6 +204,7 @@ object CHExpressionUtil {
FROM_UTC_TIMESTAMP -> UtcTimestampValidator(),
STACK -> DefaultValidator(),
RAISE_ERROR -> DefaultValidator(),
- WIDTH_BUCKET -> DefaultValidator()
+ WIDTH_BUCKET -> DefaultValidator(),
+ MAKE_DATE -> DefaultValidator()
)
}
diff --git
a/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
b/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
index 94c69abd8d..5a4af560b2 100644
---
a/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
+++
b/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
@@ -1530,4 +1530,11 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
}
+
+ test("make_date") {
+ runQueryAndCompare(
+ "select make_date(2025, 2, 7), make_date(2024, 11, null),
make_date(2024, 11, 50)") {
+ checkGlutenOperatorMatch[ProjectExecTransformer]
+ }
+ }
}
diff --git
a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
index f9b5a24461..14f912cb47 100644
---
a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
+++
b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
@@ -192,6 +192,7 @@ object ExpressionMappings {
Sig[MonthsBetween](MONTHS_BETWEEN),
Sig[DateFromUnixDate](DATE_FROM_UNIX_DATE),
Sig[UnixDate](UNIX_DATE),
+ Sig[MakeDate](MAKE_DATE),
Sig[MakeTimestamp](MAKE_TIMESTAMP),
Sig[MakeYMInterval](MAKE_YM_INTERVAL),
Sig[ToUTCTimestamp](TO_UTC_TIMESTAMP),
diff --git
a/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
b/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
index 713a6ba0dc..9e974120fa 100644
---
a/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
+++
b/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
@@ -217,6 +217,7 @@ object ExpressionNames {
final val MONTHS_BETWEEN = "months_between"
final val DATE_FROM_UNIX_DATE = "date_from_unix_date"
final val UNIX_DATE = "unix_date"
+ final val MAKE_DATE = "make_date"
final val MAKE_TIMESTAMP = "make_timestamp"
final val MAKE_YM_INTERVAL = "make_ym_interval"
final val TO_UTC_TIMESTAMP = "to_utc_timestamp"
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
