lgbo-ustc commented on code in PR #8555:
URL: https://github.com/apache/incubator-gluten/pull/8555#discussion_r1951876740
##########
gluten-ut/common/src/test/scala/org/apache/gluten/utils/BackendTestSettings.scala:
##########
@@ -98,6 +98,13 @@ abstract class BackendTestSettings {
exclusion.add(Exclude(testNames: _*))
this
}
+ def includeCH(testNames: String*): SuiteSettings = {
+ this
+ }
Review Comment:
I just consider the method names are not general for backends, They are only
used in CH test settings. How about this ?
```scala
def includeBackend(backendName, String, testNames: String*)
def excludeBackend(backendName, String, testNames: String*)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
