lgbo-ustc commented on code in PR #8550:
URL: https://github.com/apache/incubator-gluten/pull/8550#discussion_r1953929584
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHHashAggregateExecTransformer.scala:
##########
@@ -277,12 +277,24 @@ case class CHHashAggregateExecTransformer(
val childrenNodeList = new util.ArrayList[ExpressionNode]()
val childrenNodes = aggExpr.mode match {
case Partial | Complete =>
- aggregateFunc.children.toList.map(
+ val nodes = aggregateFunc.children.toList.map(
expr => {
ExpressionConverter
.replaceWithExpressionTransformer(expr, childOutput)
.doTransform(args)
})
+
+ val extraNodes = aggregateFunc match {
+ case hll: HyperLogLogPlusPlus =>
Review Comment:
If these cases become more, it should be put into a function to generate the
nodes of an aggregate function. Anyway it seems OK at present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
