JkSelf commented on code in PR #8722:
URL: https://github.com/apache/incubator-gluten/pull/8722#discussion_r1960914655
##########
backends-velox/src/test/scala/org/apache/spark/sql/execution/VeloxParquetWriteForHiveSuite.scala:
##########
@@ -330,4 +330,43 @@ class VeloxParquetWriteForHiveSuite
}
}
}
+
+ testWithSpecifiedSparkVersion(
+ "Native writer should keep the same compression codec if
`hive.exec.compress.output` is true",
+ maxSparkVersion = Some("3.3")) {
Review Comment:
It seems no need to test with specified spark version due to spark 3.4 and
later don't support native write for ctas
[here](https://github.com/apache/incubator-gluten/blob/main/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/datasources/GlutenWriterColumnarRules.scala#L92)?
If so, spark 3.4 and later will fallback to vanilla spark and align with
vanilla spark behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
