This is an automated email from the ASF dual-hosted git repository.

taiyangli pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new f883f5862e [GLUTEN-8769][CH] Fix failed uts introduced by 
approx_count_distinct (#8765)
f883f5862e is described below

commit f883f5862e771240d6f36005ce51817380785173
Author: 李扬 <[email protected]>
AuthorDate: Wed Feb 19 14:21:16 2025 +0800

    [GLUTEN-8769][CH] Fix failed uts introduced by approx_count_distinct (#8765)
    
    * fix hyperloglog ut
    
    * allow group-by-filter.sql
    
    * revert ut
---
 cpp-ch/local-engine/tests/gtest_hllpp.cpp | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/cpp-ch/local-engine/tests/gtest_hllpp.cpp 
b/cpp-ch/local-engine/tests/gtest_hllpp.cpp
index d2ca424f8e..457eb8e0e9 100644
--- a/cpp-ch/local-engine/tests/gtest_hllpp.cpp
+++ b/cpp-ch/local-engine/tests/gtest_hllpp.cpp
@@ -57,14 +57,12 @@ TEST(HyperLogLogPlusPlusDataTest, Small)
 
 TEST(HyperLogLogPlusPlusDataTest, Large)
 {
-    GTEST_SKIP();
     HyperLogLogPlusPlusData hll;
     initLargeHLL(hll);
-    EXPECT_EQ(hll.query(), 806);
+    EXPECT_EQ(hll.query(), 821);
 }
 
 TEST(HyperLogLogPlusPlusDataTest, Merge) {
-    GTEST_SKIP();
     HyperLogLogPlusPlusData hll1;
     initSmallHLL(hll1);
 
@@ -72,11 +70,10 @@ TEST(HyperLogLogPlusPlusDataTest, Merge) {
     initLargeHLL(hll2);
 
     hll1.merge(hll2);
-    EXPECT_EQ(hll1.query(), 806);
+    EXPECT_EQ(hll1.query(), 821);
 }
 
 TEST(HyperLogLogPlusPlusDataTest, SerializeAndDeserialize) {
-    GTEST_SKIP();
     HyperLogLogPlusPlusData hll1;
     initLargeHLL(hll1);
 
@@ -87,5 +84,5 @@ TEST(HyperLogLogPlusPlusDataTest, SerializeAndDeserialize) {
     HyperLogLogPlusPlusData hll2;
     hll2.deserialize(read_buffer);
 
-    EXPECT_EQ(hll2.query(), 806);
+    EXPECT_EQ(hll2.query(), 821);
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to