WangGuangxin commented on code in PR #8671:
URL: https://github.com/apache/incubator-gluten/pull/8671#discussion_r1964646036
##########
backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala:
##########
@@ -332,13 +336,27 @@ object ColumnarPartialProjectExec {
}
}
- def create(original: ProjectExec): ProjectExecTransformer = {
- val replacedAliasUdf: ListBuffer[Alias] = ListBuffer()
- val newProjectList = original.projectList.map {
- p => replaceExpressionUDF(p,
replacedAliasUdf).asInstanceOf[NamedExpression]
+ def create(original: SparkPlan): UnaryTransformSupport = {
+ val transformedPlan = original match {
+ case p: ProjectExec =>
+ val replacedAliasUdf: ListBuffer[Alias] = ListBuffer()
+ val newProjectList = p.projectList.map {
+ p => replaceExpressionUDF(p,
replacedAliasUdf).asInstanceOf[NamedExpression]
+ }
+ val partialProject =
+ ColumnarPartialProjectExec(p, p.child)(replacedAliasUdf.toSeq)
+ ProjectExecTransformer(newProjectList, partialProject)
+ case f: FilterExec =>
+ val replacedAliasUdf: ListBuffer[Alias] = ListBuffer()
+ val newCondition = splitConjunctivePredicates(f.condition)
Review Comment:
It can works under `and`, I add one more ut for this.
For `OR`, I think you are right, it's not safe to pre evalute where there
are `OR` because of short-circuit evalution. I'll fix it
##########
backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala:
##########
@@ -332,13 +336,27 @@ object ColumnarPartialProjectExec {
}
}
- def create(original: ProjectExec): ProjectExecTransformer = {
- val replacedAliasUdf: ListBuffer[Alias] = ListBuffer()
- val newProjectList = original.projectList.map {
- p => replaceExpressionUDF(p,
replacedAliasUdf).asInstanceOf[NamedExpression]
+ def create(original: SparkPlan): UnaryTransformSupport = {
+ val transformedPlan = original match {
+ case p: ProjectExec =>
+ val replacedAliasUdf: ListBuffer[Alias] = ListBuffer()
+ val newProjectList = p.projectList.map {
+ p => replaceExpressionUDF(p,
replacedAliasUdf).asInstanceOf[NamedExpression]
+ }
+ val partialProject =
+ ColumnarPartialProjectExec(p, p.child)(replacedAliasUdf.toSeq)
+ ProjectExecTransformer(newProjectList, partialProject)
+ case f: FilterExec =>
+ val replacedAliasUdf: ListBuffer[Alias] = ListBuffer()
+ val newCondition = splitConjunctivePredicates(f.condition)
Review Comment:
It can works under `and`, I added one more ut for this.
For `OR`, I think you are right, it's not safe to pre evalute where there
are `OR` because of short-circuit evalution. I'll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
