NEUpanning commented on issue #8787: URL: https://github.com/apache/incubator-gluten/issues/8787#issuecomment-2687390249
@JkSelf I found the root cause of this issue. In our internal Velox branch, we support an internal data format reader that does not allow filter push down. However, `TableScan#canAddDynamicFilter` always returns true regardless of whether the format reader supports this feature. In this case, the filters were pushed down to the format reader and did not apply to rows. I've changed ` TableScan#canAddDynamicFilter` to consider if the reader supports filter push down to resolve this issue. Do you think we should open a PR in Velox, although all format readers support this feature in Velox now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
