This is an automated email from the ASF dual-hosted git repository.

changchen pushed a commit to branch revert-8842-gluten_map_filter
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git

commit 42b6a7427c7f328fd3ebff1b6241546cb90ceb4d
Author: Chang chen <[email protected]>
AuthorDate: Mon Mar 3 09:21:13 2025 +0800

    Revert "[VL] Enable spark function map_filter (#8842)"
    
    This reverts commit 477aa6b3c840871da12c82419025035ea490e1be.
---
 .../gluten/execution/ScalarFunctionsValidateSuite.scala  | 16 ----------------
 docs/velox-backend-support-progress.md                   |  2 +-
 .../apache/gluten/expression/ExpressionMappings.scala    |  1 -
 .../org/apache/gluten/expression/ExpressionNames.scala   |  1 -
 4 files changed, 1 insertion(+), 19 deletions(-)

diff --git 
a/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
 
b/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
index 34c90e9077..5a4af560b2 100644
--- 
a/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
+++ 
b/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
@@ -614,22 +614,6 @@ abstract class ScalarFunctionsValidateSuite extends 
FunctionsValidateSuite {
     }
   }
 
-  test("map_filter") {
-    withTempPath {
-      path =>
-        Seq((Map("a" -> 1, "b" -> 2, "c" -> 3)))
-          .toDF("m")
-          .write
-          .parquet(path.getCanonicalPath)
-
-        
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("map_tbl")
-
-        runQueryAndCompare("select map_filter(m, (k, v) -> k != 'b') from 
map_tbl") {
-          checkGlutenOperatorMatch[ProjectExecTransformer]
-        }
-    }
-  }
-
   test("test transform_keys function") {
     withTempPath {
       path =>
diff --git a/docs/velox-backend-support-progress.md 
b/docs/velox-backend-support-progress.md
index 691a828db8..59e809e5f1 100644
--- a/docs/velox-backend-support-progress.md
+++ b/docs/velox-backend-support-progress.md
@@ -313,7 +313,7 @@ Gluten supports 199 functions. (Drag to right to see all 
data types)
 | map                          | map                    | map                  
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | map_concat                   | map_concat             |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | map_entries                  | map_entries            |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
-| map_filter                   | map_filter             | map_filter           
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
+| map_filter                   | map_filter             | map_filter           
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | get_map_value                |                        | element_at           
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     | S   |        |     |
 | map_from_arrays              |                        | map_from_arrays      
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     | S   |        |     |
 | map_from_entries             | map_from_entries       |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
diff --git 
a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
 
b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
index 5477abceb3..354ad9ea79 100644
--- 
a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
+++ 
b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
@@ -264,7 +264,6 @@ object ExpressionMappings {
     Sig[MapEntries](MAP_ENTRIES),
     Sig[MapZipWith](MAP_ZIP_WITH),
     Sig[StringToMap](STR_TO_MAP),
-    Sig[MapFilter](MAP_FILTER),
     Sig[TransformKeys](TRANSFORM_KEYS),
     Sig[TransformValues](TRANSFORM_VALUES),
     // Struct functions
diff --git 
a/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
 
b/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
index 4ea3227b45..2c919cebe9 100644
--- 
a/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
+++ 
b/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
@@ -289,7 +289,6 @@ object ExpressionNames {
   final val TRANSFORM_KEYS = "transform_keys"
   final val TRANSFORM_VALUES = "transform_values"
   final val STR_TO_MAP = "str_to_map"
-  final val MAP_FILTER = "map_filter"
 
   // struct functions
   final val GET_STRUCT_FIELD = "get_struct_field"


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to