ArnavBalyan commented on code in PR #8640:
URL: https://github.com/apache/incubator-gluten/pull/8640#discussion_r1976988254
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -250,8 +250,8 @@ bool SubstraitToVeloxPlanValidator::validateCast(
const auto& toType = SubstraitParser::parseType(castExpr.type());
core::TypedExprPtr input = exprConverter_->toVeloxExpr(castExpr.input(),
inputType);
- // Only support cast from date to timestamp
- if (toType->kind() == TypeKind::TIMESTAMP && !input->type()->isDate()) {
+ // Only support cast of certain types to timestamp (date and double)
+ if (toType->kind() == TypeKind::TIMESTAMP && !input->type()->isDate() &&
input->type()->kind() != TypeKind::DOUBLE) {
Review Comment:
updated thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
