jinchengchenghh commented on code in PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#discussion_r1977704250
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -152,10 +152,11 @@ WholeStageResultIterator::WholeStageResultIterator(
starts[idx],
lengths[idx],
partitionKeys,
- std::nullopt,
+ std::nullopt /*tableBucketNmae*/,
Review Comment:
tableBucketNmae -> tableBucketName typo
##########
cpp/velox/shuffle/GlutenByteStream.h:
##########
@@ -54,6 +54,8 @@ class GlutenByteInputStream : public ByteInputStream {
/// TODO Remove after refactoring SpillInput.
virtual ~GlutenByteInputStream() = default;
+ std::vector<ByteRange> ranges_;
Review Comment:
What is the usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
