PHILO-HE commented on code in PR #8640:
URL: https://github.com/apache/incubator-gluten/pull/8640#discussion_r1978845245
##########
gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala:
##########
@@ -152,4 +153,33 @@ class GlutenCastSuite extends CastSuite with
GlutenTestsTrait {
checkEvaluation(cast(Literal.create(null, IntegerType), ShortType), null)
}
+
+ test("cast from double to timestamp format") {
Review Comment:
If this test is not a variant of vanilla spark test, we prefer moving it to
some common places, not bound to one Spark version. E.g.,
`ScalarFunctoinsValidateSuite.scala` or one new dedicate test class under
backends-velox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
