PHILO-HE commented on code in PR #8886:
URL: https://github.com/apache/incubator-gluten/pull/8886#discussion_r1978779994
##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -113,21 +113,21 @@ void VeloxBackend::init(const
std::unordered_map<std::string, std::string>& conf
google::InitGoogleLogging("gluten");
// Allow growing buffer in another task through its memory pool.
- config::globalConfig.memoryPoolCapacityTransferAcrossTasks = true;
+ FLAGS_velox_memory_pool_capacity_transfer_across_tasks = true;
// Avoid creating too many shared leaf pools.
- config::globalConfig.memoryNumSharedLeafPools = 0;
+ FLAGS_velox_memory_num_shared_leaf_pools = 0;
// Set velox_exception_user_stacktrace_enabled.
- config::globalConfig.exceptionUserStacktraceEnabled =
+ FLAGS_velox_exception_user_stacktrace_enabled =
backendConf_->get<bool>(kEnableUserExceptionStacktrace,
kEnableUserExceptionStacktraceDefault);
// Set velox_exception_system_stacktrace_enabled.
- config::globalConfig.exceptionSystemStacktraceEnabled =
+ FLAGS_velox_exception_system_stacktrace_enabled =
backendConf_->get<bool>(kEnableSystemExceptionStacktrace,
kEnableSystemExceptionStacktraceDefault);
// Set velox_memory_use_hugepages.
- config::globalConfig.memoryUseHugepages =
backendConf_->get<bool>(kMemoryUseHugePages, kMemoryUseHugePagesDefault);
+ FLAGS_velox_memory_use_hugepages =
backendConf_->get<bool>(kMemoryUseHugePages, kMemoryUseHugePagesDefault);
Review Comment:
@zhztheplayer, seems we have to keep the declaration. Otherwise, an error
will be reported: xxx was not declared in this scope. If Velox removes these
flags (removing their definition), there will be a link error reported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
