jackylee-ch commented on code in PR #8907:
URL: https://github.com/apache/incubator-gluten/pull/8907#discussion_r1982452481
##########
gluten-ui/src/main/scala/org/apache/spark/sql/execution/ui/GlutenSQLHistoryServerPlugin.scala:
##########
@@ -33,5 +33,5 @@ class GlutenSQLHistoryServerPlugin extends
AppHistoryServerPlugin {
}
}
- override def displayOrder: Int = 0
+ override def displayOrder: Int = 1
Review Comment:
In my view, it would be better to set displayOrder to 1. Spark uses
displayOrder to determine the display sequence of tabs. Since SQLTab has a
displayOrder of 0 and ThriftServerTab is set to 1, using 0 might cause SQLTab
and GlutenSQLTab to appear out of order. By assigning displayOrder 1, which is
not commonly used in my experience, we can guarantee the proper ordering of the
SQLTab. Correct me if I miss something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
