PHILO-HE commented on code in PR #8634:
URL: https://github.com/apache/incubator-gluten/pull/8634#discussion_r1984501778
##########
gluten-ut/spark32/src/test/scala/org/apache/spark/sql/GlutenDataFrameSuite.scala:
##########
@@ -359,6 +360,29 @@ class GlutenDataFrameSuite extends DataFrameSuite with
GlutenSQLTestsTrait {
checkResult(df, expectedBinaryResult)
}
+ test("SPARK-27439: Explain result should match collected result after view
change - re-write") {
Review Comment:
use `testGluten("SPARK-27439: Explain result should match collected result
after view change")`. `testGluten` implies it's a variant based on Spark's
test. Then, no need to append "re-write".
##########
gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -263,6 +263,8 @@ class ClickHouseTestSettings extends BackendTestSettings {
.exclude("SPARK-24165: CaseWhen/If - nullability of nested types")
.exclude("SPARK-27671: Fix analysis exception when casting null in nested
field in struct")
.exclude("summary")
+ .exclude(
Review Comment:
Change to use `excludeGluten` when `testGluten` is used.
##########
gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -263,6 +263,8 @@ class ClickHouseTestSettings extends BackendTestSettings {
.exclude("SPARK-24165: CaseWhen/If - nullability of nested types")
.exclude("SPARK-27671: Fix analysis exception when casting null in nested
field in struct")
.exclude("summary")
+ .exclude(
+ "SPARK-27439: Explain result should match collected result after view
change - re-write")
Review Comment:
remove " - re-write".
##########
gluten-ut/spark32/src/test/scala/org/apache/spark/sql/GlutenDataFrameSuite.scala:
##########
@@ -359,6 +360,29 @@ class GlutenDataFrameSuite extends DataFrameSuite with
GlutenSQLTestsTrait {
checkResult(df, expectedBinaryResult)
}
+ test("SPARK-27439: Explain result should match collected result after view
change - re-write") {
Review Comment:
Ditto for other applicable code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
