beliefer commented on code in PR #8962:
URL: https://github.com/apache/incubator-gluten/pull/8962#discussion_r1993400044
##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -33,9 +34,13 @@ case class GlutenNumaBindingInfo(
totalCoreRange: Array[String] = null,
numCoresPerExecutor: Int = -1) {}
-class GlutenConfig(conf: SQLConf) extends Logging {
+class GlutenConfig(sessionOpt: Option[SparkSession] = None) extends Logging {
Review Comment:
You can see the tests `Gluten Clickhouse CI` is failed!
But I created another PR
https://github.com/apache/incubator-gluten/pull/8980 with the wrong method, but
the tests `Gluten Clickhouse CI` is success
You can see the difference between this PR and
https://github.com/apache/incubator-gluten/pull/8980 is just one line.
This PR uses `def conf: SQLConf =
sessionOpt.map(_.sessionState.conf).getOrElse(SQLConf.get)`
But https://github.com/apache/incubator-gluten/pull/8980 uses `val conf:
SQLConf = sessionOpt.map(_.sessionState.conf).getOrElse(SQLConf.get)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
