zhztheplayer commented on PR #8950: URL: https://github.com/apache/incubator-gluten/pull/8950#issuecomment-2717262698
As the APIs are mostly `public static`, I think the synchronisations are not completely meaningless. But there seems to be a problem that the synchronisations code is a little bit messy. Can we use a simple way to synchronize the code? E.g., by simply adding `synchronzized` keyword to all the public methods. Performance will not be an issue here, the APIs are expected only to be called a few times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
