PHILO-HE commented on code in PR #8593:
URL: https://github.com/apache/incubator-gluten/pull/8593#discussion_r1994895843
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -263,8 +263,16 @@ bool SubstraitToVeloxPlanValidator::isAllowedCast(const
TypePtr& fromType, const
// Limited support for X to Timestamp.
if (toType->isTimestamp() && !(fromType->isDate() || fromType->isVarchar()))
{
- LOG_VALIDATION_MSG("Casting from " + fromType->toString() + " to TIMESTAMP
is not supported.");
- return false;
+ switch (fromType->kind()) {
+ case TypeKind::TINYINT:
Review Comment:
@jackylee-ch, just moved and also use isXXX() to replace TypeKind check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
