jackylee-ch commented on code in PR #9016:
URL: https://github.com/apache/incubator-gluten/pull/9016#discussion_r2000218299
##########
backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala:
##########
@@ -123,6 +123,54 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ testWithSpecifiedSparkVersion("Test array_append function - INT",
Some("3.4")) {
+ withTempPath {
+ path =>
+ Seq[(Array[Int], Int)](
+ (Array(2, 1), 0),
+ (Array(1), 1),
+ (Array(), 0),
+ (Array(1, 2, null.asInstanceOf[Int]), 1),
+ (Array(null.asInstanceOf[Int]), 1),
+ (Array(null.asInstanceOf[Int]), null.asInstanceOf[Int]),
+ (Array(), null.asInstanceOf[Int])
Review Comment:
please add `(null, 1)` to test, as vanilla spark return null for `SELECT
array_append(CAST(null as Array<Int>), 2);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
