ArnavBalyan commented on PR #9011: URL: https://github.com/apache/incubator-gluten/pull/9011#issuecomment-2735540302
> It would be better to have `GlutenCastSuite` extend `CastWithAnsiOffSuite` instead of `CastSuiteBase`. Then, we can keep `GlutenTryCastSuite` for ANSI mode. Thanks, for Gluten do you think we want to run tests for ANSI mode enabled? Since it's not supported and unit tests may not work as expected. It seems we correctly run it with ANSI off for Spark 32,33 however behaviour changed due to Spark 34/35. Pls let me know your thoughts thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
