marin-ma commented on PR #9005: URL: https://github.com/apache/incubator-gluten/pull/9005#issuecomment-2736070875
@kerwin-zk I see. So the current modifications cannot work. `VeloxRssSortShuffleReaderDeserializer::VeloxInputStream` need to extend `ByteInputStream` interface to support this logic. `GlutenByteInputStream` is a copy from the deprecated code in Velox. It's better to do the cleanup and only keep the logic we need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
